feat(cli): abort tk show when stdout is being piped
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
reject_ks_show_pipe
branch
from
45a10d7
to
26d0454
Compare
sh0rez
requested changes
Aug 14, 2019
…edirect --dangerous-allow-redirect bypasses check for running in an interactive terminal. This flag should be passed if the user wants to redirect the output of tk show to a pipe or a file.
|
@sh0rez made all the requested changes, PTAL |
sh0rez
approved these changes
Aug 14, 2019
|
Awesome, thanks! |
sh0rez
changed the title
tk show when stdout is being pipedtk show when stdout is being piped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Closes #49