Helm Charts: Prevent vendor panic by adding validation #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charts with a custom directory defined are getting pruned 🤦
julienduchesne
force-pushed
the
julienduchesne/helm-fix-prune
branch
from
823cd03
to
94b29a7
Compare
This one was pre-existing :) Given this chartfile: ```yaml repositories: - name: prefect url: https://prefecthq.github.io/server/ requires: - chart: prefect version: '2022.04.14' version: 1 ``` We get a panic because the name cannot be split into its two parts It's not possible to add this dependency using the `add` command but given that we want to also support manual edits to the yaml file, additional validation can be nice
julienduchesne
force-pushed
the
julienduchesne/helm-fix-panic
branch
from
9823e5f
to
3b9a6de
Compare
iainlane
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was pre-existing :)
Given this chartfile:
We get a panic because the name cannot be split into its two parts
It's not possible to add this dependency using the
addcommand but given that we want to also support manual edits to the yaml file, additional validation can be nice