Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exact match to find context from API server #750

Merged
merged 1 commit into from Sep 11, 2022
Merged

Use exact match to find context from API server #750

merged 1 commit into from Sep 11, 2022

Conversation

julienduchesne
Copy link
Contributor

Currently, if you have two contexts:

  • my-cluster-dev
  • my-cluster and you try to apply to my-cluster, it will match the first one

@julienduchesne
Use exact match to find context from API server
b958a36 
Currently, if you have two contexts:
- my-cluster-dev
- my-cluster
and you try to apply to `my-cluster`, it will match the first one
@julienduchesne julienduchesne requested a review from a team September 7, 2022 17:17
iainlane
iainlane approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, looks fine but I think you could avoid the regex at least in this case, maybe in all the others (shouldn't they all be an exact match?)

@julienduchesne julienduchesne merged commit a331018 into main Sep 11, 2022
@julienduchesne julienduchesne deleted the julienduchesne/find-context-exact-match branch September 11, 2022 23:04
@julienduchesne julienduchesne mentioned this pull request Jan 27, 2023
Closed
@julienduchesne julienduchesne mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @iainlane