Helm: Handle dirs missing the Chart.yaml file
#752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #749 Currently, the case where a chart dir is missing is handled by the `vendor` command, the dir will be re-vendored However, if the dir is emptied (an example is git, which tracks files but not dirs, if a chart deletion is pulled from git, the dir will remain), Tanka throws an error
julienduchesne
added a commit
that referenced
this pull request
Sep 12, 2022
Currently, two Drone runs are triggered, one for the push to the branch and one for the PR Example: #752 With this change, only one CI run will be triggered on PRs
julienduchesne
added a commit
that referenced
this pull request
Sep 12, 2022
Currently, two Drone runs are triggered, one for the push to the branch and one for the PR Example: #752 With this change, only one CI run will be triggered on PRs
jjo
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749
Currently, the case where a chart dir is missing is handled by the
vendorcommand, the dir will be re-vendoredHowever, if the dir is emptied (an example is git, which tracks files but not dirs, if a chart deletion is pulled from git, the dir will remain), Tanka throws an error