Add benchmark function for getSnippetHash #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchstat (compared to main): |
The benchstat is empty because we have nothing to compare with in the main branch. However, once this is merged, the future PRs will look like grafana/jsonnet-language-server#74 (comment) |
julienduchesne
force-pushed
the
julienduchesne/add-benchmark
branch
from
25f38e7
to
5e737ce
Compare
inkel
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to compare performance in a future PR
I also added a workflow that posts a comparison of all benchmarks in the project. If we want to improve performance elsewhere, it'll be easier to do so. I will definitely need to do so on a feature I'm working on