tk export: Expand merging capabilities with --merge-strategy flag
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchstat (compared to main): |
Documented in `exporting.md`. This option allows us to delete the previously exported manifests for an environment. This is useful when exporting a single environment and merging the result with an existing GitOps repository, rather than re-exporting all environments. I also added benchmark and a test for the export code.
julienduchesne
force-pushed
the
julienduchesne/add-delete-previous
branch
from
372e749
to
628c729
Compare
julienduchesne
force-pushed
the
julienduchesne/add-delete-previous
branch
from
6629165
to
5ae2be3
Compare
inkel
reviewed
Sep 23, 2022
julienduchesne
changed the title
--delete-previous option to tk exporttk export: Expand merging capabilities with --merge-strategy flag
All input is valued, regardless of status. Thanks! |
julienduchesne
added a commit
that referenced
this pull request
Oct 3, 2022
This command is powerful when used with the `--merge-strategy=replace-envs` flag added here: #760 Given a repository with a large number of Tanka environments, exporting the whole set can be very time consuming if done on every commit. What a user probably wants to do is to only export the environments that have changed. To do this, we need to actually find out what files affect which environments, and this is what this new command does. A user can now pass the list of files modified in a git commit, and run `tk export` on the set of environments affected by those files.
julienduchesne
added a commit
that referenced
this pull request
Oct 3, 2022
This command is powerful when used with the `--merge-strategy=replace-envs` flag added here: #760 Given a repository with a large number of Tanka environments, exporting the whole set can be very time consuming if done on every commit. What a user probably wants to do is to only export the environments that have changed. To do this, we need to actually find out what files affect which environments, and this is what this new command does. A user can now pass the list of files modified in a git commit, and run `tk export` on the set of environments affected by those files.
julienduchesne
added a commit
that referenced
this pull request
Oct 4, 2022
* Add new `tk tool importers` command This command is powerful when used with the `--merge-strategy=replace-envs` flag added here: #760 Given a repository with a large number of Tanka environments, exporting the whole set can be very time consuming if done on every commit. What a user probably wants to do is to only export the environments that have changed. To do this, we need to actually find out what files affect which environments, and this is what this new command does. A user can now pass the list of files modified in a git commit, and run `tk export` on the set of environments affected by those files. * Add comments and simplify functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented in
exporting.md. This option expands the existing--mergeflag (now deprecated) to allow us to delete the previously exported manifests for an environment before exporting. This strategy has been in-use (in private code) for about 6 months here at Grafana Labs.This is useful when exporting a single environment and merging the result with an existing GitOps repository, rather than re-exporting all environments.
I also added benchmark and a test for the export code.