Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy website to Github Pages #793

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Dec 6, 2022

This gets rid of netlify which we don't really need and is blocking PRs like #783 This contains two different parts:

  • A step that deploys to a preview for PRs
  • A step that deploys on a push to main

NOTE: Netlify is failing on this PR as well, I will remove the Netlify webhook once this is deployed and I've validated it works

@julienduchesne julienduchesne force-pushed the julienduchesne/deploy-to-github-pages branch 2 times, most recently from e6caed0 to d68c9b0 Compare December 6, 2022 02:00
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2022-12-06 15:27 UTC

@julienduchesne julienduchesne force-pushed the julienduchesne/deploy-to-github-pages branch 2 times, most recently from 644508b to ba3ebe8 Compare December 6, 2022 02:16
This gets rid of netlify which we don't really need and is blocking PRs like #783
This contains two different parts:
- A step that deploys to a preview for PRs
- A step that deploys on a push to main
@julienduchesne julienduchesne force-pushed the julienduchesne/deploy-to-github-pages branch from ba3ebe8 to 2fd586f Compare December 6, 2022 02:28
@julienduchesne julienduchesne marked this pull request as ready for review December 6, 2022 02:32
@julienduchesne julienduchesne requested review from sh0rez, Duologic and a team December 6, 2022 02:33
Copy link
Contributor

@salvacorts salvacorts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienduchesne julienduchesne merged commit 08ddf95 into main Dec 6, 2022
@julienduchesne julienduchesne deleted the julienduchesne/deploy-to-github-pages branch December 6, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants