Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Support OCI #866

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Helm: Support OCI #866

merged 1 commit into from
Jun 6, 2023

Conversation

julienduchesne
Copy link
Member

Closes #830

To support OCI registries for Helm charts:

  • we need to pass the full URL when pulling those charts
  • versioning is not necessarily semver now
  • the repo update cmd is a no-op for OCI packages but still necessary for Helm repositories

@julienduchesne julienduchesne requested review from logyball and a team May 15, 2023 15:46
Closes #830
To support OCI registries for Helm charts:
- we need to pass the full URL when pulling those charts
- versioning is not necessarily semver now
- the `repo update` cmd is a no-op for OCI packages but still necessary for Helm repositories
@github-actions
Copy link

github-actions bot commented May 15, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-06 12:43 UTC

Copy link
Contributor

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M 👍

I attempted to verify it with the reproduction steps described in #830 but the add-repo command seems incorrect.

I was able to verify this as working with:

tk tool charts init
tk tool charts add-repo karpenter oci://public.ecr.aws/karpenter
tk tool charts add karpenter/karpenter@v0.27.1
$ tk tool charts add karpenter/karpenter@v0.27.1
{"level":"info","time":"2023-06-06T11:36:29+02:00","message":"Adding 1 Charts ..."}
{"level":"info","time":"2023-06-06T11:36:29+02:00","message":"OK: karpenter/karpenter@v0.27.1"}
{"level":"info","time":"2023-06-06T11:36:29+02:00","message":"Added 1 Charts to helmfile.yaml. Vendoring ..."}
{"level":"info","time":"2023-06-06T11:36:29+02:00","message":"Vendoring..."}
{"level":"info","time":"2023-06-06T11:36:29+02:00","message":"Syncing Repositories ..."}
{"level":"info","time":"2023-06-06T11:36:30+02:00","message":"Pulling Charts ..."}
Pulled: public.ecr.aws/karpenter/karpenter:v0.27.1
Digest: sha256:3423c1f0636177cf3894d986759831a952307092528e761c4942660a5f39417e
{"level":"info","time":"2023-06-06T11:36:32+02:00","message":"karpenter/karpenter@v0.27.1 downloaded"}

@julienduchesne julienduchesne merged commit f953ec3 into main Jun 6, 2023
3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/helm-oci branch June 6, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tk tool charts vendor does not work with oci:// protocol
2 participants