Iainlane/move impl outwards #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanka currently evals jsonnet using the Go native code. However, some other implementations have come up in the past years that could be worth using (ex: https://github.com/CertainLach/jrsonnet, which is much faster) In this PR is the first step: I create an interface where all the jsonnet eval code happens. The Go Jsonnet implementation is now hidden behind this interface. The setting can either be passed as a global flag or as an env spec attribute to be used when exporting (`spec.exportJsonnetImplementation`)
`VM` -> `Evaluator` Add some docstrings Add some comments
Add the `path` as a struct member of the Go-jsonnet implementation. We have this available when we construct the loader. This lets us then drop the same argument from `EvaluateAnonymousSnippet()` in the interface - as not all implementations need it.
|
julienduchesne
added a commit
that referenced
this pull request
Aug 24, 2023
Since #916, the JsonnetImplementation option is not used in the jsonnet package, so the jsonnet package doesn't need to know it This removes the option there and shift it up to the `tanka.Opts` struct which is where the jsonnet implementation to use is determined
julienduchesne
added a commit
that referenced
this pull request
Aug 25, 2023
Since #916, the JsonnetImplementation option is not used in the jsonnet package, so the jsonnet package doesn't need to know it This removes the option there and shift it up to the `tanka.Opts` struct which is where the jsonnet implementation to use is determined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.