Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drone -> Github Actions #938

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Drone -> Github Actions #938

merged 1 commit into from
Oct 27, 2023

Conversation

julienduchesne
Copy link
Member

From our internal Drone instance to public Github actions runners

@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-27 12:15 UTC

@julienduchesne julienduchesne force-pushed the julienduchesne/github-actions branch 8 times, most recently from 253bc6e to 8ce56a2 Compare October 27, 2023 01:29
@julienduchesne julienduchesne marked this pull request as ready for review October 27, 2023 01:31
@julienduchesne julienduchesne requested a review from a team October 27, 2023 01:31
@julienduchesne
Drone -> Github Actions
57c05e2 
From our internal Drone instance to public Github actions runners
iainlane
iainlane approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Admittedly I didn't review the new workflows to make sure they match the previous exactly but we'll find out soon enough.

The biggest thing to watch out for here is the huge increase in arm64 build time: 41s vs. 7m53s, due to the switch from a native builder to emulation. It might be worth doing the Go build as a cross-build by setting GOARCH instead of emulating it, to get around at least some of this.

@julienduchesne
Copy link
Member Author

Nice one. Admittedly I didn't review the new workflows to make sure they match the previous exactly but we'll find out soon enough.

The biggest thing to watch out for here is the huge increase in arm64 build time: 41s vs. 7m53s, due to the switch from a native builder to emulation. It might be worth doing the Go build as a cross-build by setting GOARCH instead of emulating it, to get around at least some of this.

A lot of the time is spent installing jb as well, but we could get it from their github releases instead. So yeah, some optimization could be made for sure

@julienduchesne julienduchesne merged commit 33e9f14 into main Oct 27, 2023
8 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/github-actions branch October 27, 2023 12:06
@jvrplmlmn
Copy link
Contributor

Should we cut a new release to make sure that the GHA based CI system works as expected? :D

@julienduchesne
Copy link
Member Author

Should we cut a new release to make sure that the GHA based CI system works as expected? :D

I will. I have some speed improvements to make first

julienduchesne added a commit that referenced this pull request Oct 27, 2023
@julienduchesne
Docker+CI: More efficient build
3c0a2be 
CI was moved to GHA here: #938
However, it turns out that `buildx` is pretty slow. Improvements in this PR:
- Remove `apk add curl` where easily doable
- Download `jb` from Github releases rather than building it
- Build `tk` exec outside of Docker
@julienduchesne julienduchesne mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julienduchesne @jvrplmlmn @iainlane