Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support upgrades of the instance #296

Closed
2 tasks done
pavolloffay opened this issue Mar 13, 2023 · 2 comments · Fixed by #424 or #441
Closed
2 tasks done

Support upgrades of the instance #296

pavolloffay opened this issue Mar 13, 2023 · 2 comments · Fixed by #424 or #441
Milestone
Operator level 4

Comments

@pavolloffay
Copy link
Collaborator

pavolloffay commented Mar 13, 2023 •
edited by andreasgerstmayr

Tasks
Beta Give feedback
@pavolloffay pavolloffay added this to the Operator level 4 milestone Mar 13, 2023
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue May 26, 2023
@andreasgerstmayr
Implement operator upgrade
58f5db3 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr mentioned this issue May 26, 2023
Merged
@andreasgerstmayr
Copy link
Collaborator

@pavolloffay how should the upgrade test work?

Something like

  • install the currently released 0.1.0 from operatorhub
  • build a bundle from the current git commit
  • upgrade via OLM and make sure the images in the deployments are replaced?

@pavolloffay
Copy link
Collaborator Author

👍🏼 LGTM

@andreasgerstmayr andreasgerstmayr mentioned this issue Jun 1, 2023
Closed
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 1, 2023
@andreasgerstmayr
Implement operator upgrade
a45562e 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 2, 2023
@andreasgerstmayr
Squashed commit of the following:
0cdeb23 
commit 12316537e1cfbb9d29345855a48f616b61023915
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Thu Jun 1 23:58:15 2023 +0200

    Set tempo and tempoQuery versions on upgrade

    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

commit d2b0874
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Fri May 26 16:23:34 2023 +0200

    Fix linter issues

    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

commit a45562e
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Fri May 26 12:14:22 2023 +0200

    Implement operator upgrade

    Resolves: grafana#296
    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

commit 68024a4
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Fri May 26 14:06:36 2023 +0200

    Partially revert a4a44a7

    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

commit 0a7fc9f
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Thu May 25 11:22:06 2023 +0200

    Update tests

    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

commit 3afa311
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Wed May 24 17:17:33 2023 +0200

    Set tempo and tempoQuery versions for new CRs

    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

commit e877ffb
Author: Andreas Gerstmayr <agerstmayr@redhat.com>
Date:   Mon May 22 15:22:02 2023 +0200

    Store tempo and tempo-query version in operator binary

    Required for grafana#400
    Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 2, 2023
@andreasgerstmayr
Implement operator upgrade
d2c3e31 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 2, 2023
@andreasgerstmayr
OLM upgrade test
7c06390 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr mentioned this issue Jun 2, 2023
Merged
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 6, 2023
@andreasgerstmayr
Implement operator upgrade
2219c01 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 6, 2023
@andreasgerstmayr
OLM upgrade test
61cb04c 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 7, 2023
@andreasgerstmayr
Implement operator upgrade
653057a 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 13, 2023
@andreasgerstmayr
OLM upgrade test
66e695d 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 21, 2023
@andreasgerstmayr
Implement operator upgrade
1e16ae5 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Jun 21, 2023
@andreasgerstmayr
Implement operator upgrade
ebcef9f 
Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@pavolloffay pavolloffay mentioned this issue Jun 22, 2023
Closed
pavolloffay pushed a commit that referenced this issue Jun 22, 2023
@andreasgerstmayr
Implement operator upgrade (#424)
1165a96 
* Implement operator upgrade

Resolves: #296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Drop managed-by label if spec.ManagementState is Unmanaged

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Add suggestions from code review

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Check if defaultimages is empty before setting, update webhook log messages

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Workaround empty status.operatorVersion field

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Add manual upgrade instructions using manifests

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Update logger name

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* remove tempoQuery version from status field

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* respect managementState field instead of managed-by label

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Move manual upgrade instructions to CONTRIBUTING.md

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update log message

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org in manual upgrade instructions

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org in import path

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* re-add .status.tempoQueryVersion to the CRD to avoid a breaking change

And mark it as deprecated.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
pavolloffay pushed a commit to openshift/grafana-tempo-operator that referenced this issue Jun 27, 2023
@andreasgerstmayr @pavolloffay
Implement operator upgrade (grafana#424)
069514d 
* Implement operator upgrade

Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Drop managed-by label if spec.ManagementState is Unmanaged

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Add suggestions from code review

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Check if defaultimages is empty before setting, update webhook log messages

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Workaround empty status.operatorVersion field

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Add manual upgrade instructions using manifests

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Update logger name

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* remove tempoQuery version from status field

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* respect managementState field instead of managed-by label

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Move manual upgrade instructions to CONTRIBUTING.md

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update log message

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org in manual upgrade instructions

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org in import path

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* re-add .status.tempoQueryVersion to the CRD to avoid a breaking change

And mark it as deprecated.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
pavolloffay added a commit that referenced this issue Jun 27, 2023
@andreasgerstmayr @pavolloffay
OLM upgrade test (#441)
12d8b25 
* OLM upgrade test

Resolves: #296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Use Ubuntu 22.04 for upgrade tests

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update deployment name

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Remove parameterization

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay added a commit to pavolloffay/tempo-operator that referenced this issue Jun 27, 2023
@andreasgerstmayr @pavolloffay
OLM upgrade test (grafana#441)
5f8ea02 
* OLM upgrade test

Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Use Ubuntu 22.04 for upgrade tests

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update deployment name

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Remove parameterization

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay added a commit to openshift/grafana-tempo-operator that referenced this issue Jun 27, 2023
@andreasgerstmayr @pavolloffay
OLM upgrade test (grafana#441)
7fb277f 
* OLM upgrade test

Resolves: grafana#296
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Use Ubuntu 22.04 for upgrade tests

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update deployment name

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* update org

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Remove parameterization

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Operator level 4
2 participants
@andreasgerstmayr @pavolloffay