Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run upgrade procedure when TempoStack is switched from Unmanaged to Managed #478

Closed
andreasgerstmayr opened this issue Jun 22, 2023 · 1 comment · Fixed by #548
Closed

Run upgrade procedure when TempoStack is switched from Unmanaged to Managed #478

andreasgerstmayr opened this issue Jun 22, 2023 · 1 comment · Fixed by #548
Labels
bug Something isn't working

Comments

@andreasgerstmayr
Copy link
Collaborator

andreasgerstmayr commented Jun 22, 2023 •
edited by pavolloffay

Related to: #296
@andreasgerstmayr andreasgerstmayr mentioned this issue Jun 22, 2023
Merged
@andreasgerstmayr andreasgerstmayr added the bug Something isn't working label Jul 6, 2023
@andreasgerstmayr
Copy link
Collaborator Author

The upgrade procedure needs to be run as part of the Reconcile loop (when the TempoStack is switched from Unmanaged to Managed), additionally to operator startup (because reconcile won't run if there are no changes to the CR).

andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Aug 9, 2023
@andreasgerstmayr
Support upgrading previously unmanaged instances
63d6aff 
Previously, the operator performed upgrades only at operator startup.
This is a problem if a TempoStack instance gets switched from Unmanaged
to Managed - in this case, the operator should perform the upgrade once
the TempoStack is managed again.

This commit runs the upgrade process in the reconcile loop to cater to
the above use case.

Resolves: grafana#478
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr mentioned this issue Aug 9, 2023
Merged
andreasgerstmayr added a commit that referenced this issue Sep 12, 2023
@andreasgerstmayr
Support upgrading previously unmanaged instances (#548)
d825302 
* Support upgrading previously unmanaged instances

Previously, the operator performed upgrades only at operator startup.
This is a problem if a TempoStack instance gets switched from Unmanaged
to Managed - in this case, the operator should perform the upgrade once
the TempoStack is managed again.

This commit runs the upgrade process in the reconcile loop to cater to
the above use case.

Resolves: #478
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* handle upgrade errors

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support upgrading previously unmanaged instances andreasgerstmayr/tempo-operator
1 participant
@andreasgerstmayr