add parens

Signed-off-by: Joe Elliott <number101010@gmail.com>

pkg/traceql/ast_conditions.go

@@ -44,7 +44,7 @@ func (o *BinaryOperation) extractConditions(request *FetchSpansRequest) {
 	case Attribute:
 		switch o.RHS.(type) {
 		case Static:
-			if o.RHS.(Static).Type == TypeNil && o.Op == OpNotEqual || !o.Op.isBoolean() { // the fetch layer can't build predicates on operators that are not boolean
+			if (o.RHS.(Static).Type == TypeNil && o.Op == OpNotEqual) || !o.Op.isBoolean() { // the fetch layer can't build predicates on operators that are not boolean
 				request.appendCondition(Condition{
 					Attribute: o.LHS.(Attribute),
 					Op:        OpNone,
@@ -84,7 +84,7 @@ func (o *BinaryOperation) extractConditions(request *FetchSpansRequest) {
 			// 2 statics, don't need to send any conditions
 			return
 		case Attribute:
-			if o.LHS.(Static).Type == TypeNil && o.Op == OpNotEqual || !o.Op.isBoolean() { // the fetch layer can't build predicates on operators that are not boolean
+			if (o.LHS.(Static).Type == TypeNil && o.Op == OpNotEqual) || !o.Op.isBoolean() { // the fetch layer can't build predicates on operators that are not boolean
 				request.appendCondition(Condition{
 					Attribute: o.RHS.(Attribute),
 					Op:        OpNone,

pkg/traceql/ast_conditions_test.go

@@ -97,6 +97,14 @@ func TestSpansetFilter_extractConditions(t *testing.T) {
 			},
 			allConditions: true,
 		},
+		{
+			query: `{ (.foo = 2) && (.bar / 1 > 3) }`,
+			conditions: []Condition{
+				newCondition(NewAttribute("foo"), OpEqual, NewStaticInt(2)),
+				newCondition(NewAttribute("bar"), OpNone),
+			},
+			allConditions: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.query, func(t *testing.T) {