Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to access status_message standard field from span_metrics #1764

Closed
alsterg opened this issue Sep 27, 2022 · 1 comment · Fixed by #1786 or #1794
Closed

Ability to access status_message standard field from span_metrics #1764

alsterg opened this issue Sep 27, 2022 · 1 comment · Fixed by #1786 or #1794
Assignees
Labels
good first issue Good for newcomers

Comments

@alsterg
Copy link

alsterg commented Sep 27, 2022

Is your feature request related to a problem? Please describe.
I'm trying to extract the status.message attribute from a span using span_metrics processor, but it doesn't seem to work. I can see in my traces that this attribute is set, but Tempo metric-generator will not pick it up. I wonder if it is the same issue as in this OpenTelementry bug: open-telemetry/opentelemetry-collector-contrib#14175

Describe the solution you'd like
I should be able to do:

          span_metrics:
            dimensions:
            - status.message

and pull the status.message out from Span attributes.

Describe alternatives you've considered
I tried to use OpenTelemetry Collector to do the same (with the attribute processor), but it is not feasible there too.

Additional context
I had a slack conversation with Koenraad, who acknowledge the issue:
"So it seems to be a field set on the Status object of a span (so next to status.code). The way the span metrics processor is designed we only look for field names in the span and resource attributes. status.message isn’t an attribute but a built-in field and can not be looked up this way. If you want you can open an issue for this, we can consider adding it so that if you specify status.message we now to look in the status object."

@joe-elliott joe-elliott added the good first issue Good for newcomers label Sep 27, 2022
@joe-elliott
Copy link
Member

I agree with Koenraad's take here. This shouldn't be too difficult to add if anyone wants to take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
3 participants