Metrics generator: extract status_message field from spans #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoewer
changed the title
Extract the standard span field 'status_message' or 'status.message' when it is provided in span_metrics dimensions.
stoewer
force-pushed
the
status-message-from-span-metrics
branch
from
156ce01
to
da75f59
Compare
stoewer
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
mapno
approved these changes
Oct 6, 2022
mapno
reviewed
Oct 6, 2022
Co-authored-by: Mario <mariorvinas@gmail.com>
gouthamve
pushed a commit
to gouthamve/tempo
that referenced
this pull request
Oct 6, 2022
) * Generator: extract status_message field Extract the standard span field 'status_message' or 'status.message' when it is provided in span_metrics dimensions. * Mention dimension lookup inside span status in config docs * Update config documentation regarding status.message lookup. Co-authored-by: Mario <mariorvinas@gmail.com> Co-authored-by: Mario <mariorvinas@gmail.com> Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
joe-elliott
pushed a commit
to joe-elliott/tempo
that referenced
this pull request
Oct 7, 2022
) * Generator: extract status_message field Extract the standard span field 'status_message' or 'status.message' when it is provided in span_metrics dimensions. * Mention dimension lookup inside span status in config docs * Update config documentation regarding status.message lookup. Co-authored-by: Mario <mariorvinas@gmail.com> Co-authored-by: Mario <mariorvinas@gmail.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When generating span metrics, extract the non attribute field
status_messageorstatus.message, when it is provided in the span_metrics dimensions.Which issue(s) this PR fixes:
Fixes #1764
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]