Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TraceQL] Enhance Autocomplete to Differentiate Resource and Span Attributes #2471

Closed
faustodavid opened this issue May 12, 2023 · 2 comments

Comments

@faustodavid
Copy link
Contributor

faustodavid commented May 12, 2023

Is your feature request related to a problem? Please describe.
When using TraceQL, I noticed that when I write {resource.}, I receive suggestions for all possible attributes from both the resource and span scope. This can be overwhelming when I only want to see the attributes specific to either the resource or the span.
image

Describe the solution you'd like
I would like to propose that typing . returns all possible attributes, typing resource. only displays the resource attributes, and typing span. only displays the span attributes. This would enhance the usability and make it easier to navigate and select the desired attributes based on the scope we are working with.

@joe-elliott
Copy link
Member

joe-elliott commented May 12, 2023

Great call out! We added support here: #2282

and there's an issue here to add support in Grafana: grafana/grafana#67011

Looks like there's a PR open! #2471

@joe-elliott
Copy link
Member

I'm normally terrible about closing issues b/c I want there to be discussion even if it's not something we agree with or have time to work on, but this one seems pretty covered.

Thanks @faustodavid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants