Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jsonnet-libs 1.19 and update tk examples #1001

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented Sep 30, 2021

What this PR does:

Upgrade jsonnet-libs to 1.19 and update tk examples.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno changed the title Upgrade jsonnet-libs to 1.19 and update tk examples Upgrade to jsonnet-libs 1.19 and update tk examples Sep 30, 2021
@joe-elliott joe-elliott self-assigned this Sep 30, 2021
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both single-binary and microservices.

Any idea why it added a billion new files?

@kvrhdn
Copy link
Member

kvrhdn commented Oct 1, 2021

This PR changes a dependency from https://github.com/ksonnet/ksonnet-lib to https://github.com/jsonnet-libs/k8s-libsonnet. So vendoring has to replace an entire repo.

CHANGELOG.md Outdated Show resolved Hide resolved
mapno and others added 2 commits October 4, 2021 11:00
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
@mapno mapno merged commit 44cbb18 into grafana:main Oct 4, 2021
@mapno mapno deleted the update-jsonnet branch October 4, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants