Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable hedged requests up to #1085

Merged
merged 7 commits into from Nov 8, 2021

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Oct 27, 2021

What this PR does:
Marked as draft b/c we should hold on merging til after 1.2 is cut.

  • Makes the "upto" parameter of hedged requests configurable
  • Updates s3/gcs backend clients. I did not upgrade the azure backend client b/c it got caught up in thanos and cortex upgrades. We should do that in a seperate PR.

Todo: changelog

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@mdisibio mdisibio added this to the v1.3 milestone Oct 27, 2021
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Copy link
Member Author

1.2 is released and this is ready.

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-elliott joe-elliott merged commit dcc3bde into grafana:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants