Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonnet lib for Grafana Enterprise Traces #1096

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Nov 3, 2021

What this PR does:

This PR adds a jsonnet library for Grafana Enterprise Traces.

Closes https://github.com/grafana/backend-enterprise/issues/2593

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

chaudum added a commit that referenced this pull request Nov 3, 2021
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum marked this pull request as ready for review November 3, 2021 10:09
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>

Add simple verification tooling for GET jsonnet lib

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>

Add changelog entry for #1096

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Copy link
Contributor Author

chaudum commented Nov 4, 2021

@joe-elliott Is the failing test a know flaky test? Could you please merge this PR as I do not have permissions to do so?

@joe-elliott joe-elliott merged commit bde7d6d into main Nov 5, 2021
@joe-elliott joe-elliott deleted the chaudum/enterprise-jsonnet branch November 5, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants