Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise jsonnet: add config to create tokengen job explicitly #1256

Merged

Conversation

kvrhdn
Copy link
Member

@kvrhdn kvrhdn commented Jan 27, 2022

What this PR does:
The jsonnet for GET creates a job to generate the token from a GET license (tokengen). This job should be created once when installing GET and the job can not be modified afterwards. To make this easier to manage, this PR adds a config option run_tokengen_job which is disabled by default and can be set to explicitly create the tokengen job.

How it works:

The first time a GET cluster is created the user should set:

  _config+:: {
    run_tokengen_job: true,
  },

During tk apply, tanka will create the tokengen job (just like before). After the job has run, the user should remove this line and the tokengen job will not be modified anymore by tanka.

Which issue(s) this PR fixes:
Fixes #

Checklist

@kvrhdn kvrhdn changed the title Enterprise jsonnet: add config to create tokengen job once Enterprise jsonnet: add config to create tokengen job explicitly Jan 28, 2022
@kvrhdn kvrhdn marked this pull request as ready for review January 28, 2022 15:19
Copy link
Contributor

@hedss hedss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you for doing this!

@kvrhdn kvrhdn merged commit f0c8390 into grafana:main Jan 28, 2022
@kvrhdn kvrhdn deleted the kvrhdn/jsonnet-enterprise-run-tokengen-once branch January 28, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants