Allow GCS config for setting attributes on new objects #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
reviewed
Apr 8, 2022
mdisibio
reviewed
Apr 8, 2022
|
Looks like I was wrong about the default yaml unmarshaling tags for the upstream config object, perhaps because the underlying type is an interface. I think we'll probably want to build a config for the features we plan to support. Thought, using the default lowercase name for the yaml field does seem to work. This would be simpler than translating between the objects. Integration tests will soon tell us something. |
zalegrala
force-pushed
the
gcsObjectAttributes
branch
2 times, most recently
from
96c1d91
to
dc2af8a
Compare
joe-elliott
reviewed
Apr 11, 2022
zalegrala
force-pushed
the
gcsObjectAttributes
branch
2 times, most recently
from
880f6de
to
9d33c11
Compare
zalegrala
force-pushed
the
gcsObjectAttributes
branch
from
9d33c11
to
c0f2ee6
Compare
joe-elliott
reviewed
Apr 12, 2022
zalegrala
force-pushed
the
gcsObjectAttributes
branch
from
137b9d0
to
fc18c68
Compare
zalegrala
requested review from
KMiller-Grafana,
annanay25,
dgzlopes,
mapno and
kvrhdn
as code owners
joe-elliott
approved these changes
Apr 12, 2022
zalegrala
added a commit
to zalegrala/tempo
that referenced
this pull request
Apr 12, 2022
1 task
zalegrala
added a commit
to zalegrala/tempo
that referenced
this pull request
Apr 12, 2022
zalegrala
added a commit
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we add two options to configure GCS object attributes. One to control the aspects of object caching, and the other to allow users to specify metadata on the object.
Which issue(s) this PR fixes:
Fixes #1348
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]