Set MaxIdleConns and MaxIdleConnsPerHost for Azure backend #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
|
|
electron0zero
changed the title
|
Tested this change internally, and it has reduced errors from 4-5 errors per hour to 1 error every 2-3 hours
|
joe-elliott
approved these changes
Aug 22, 2022
|
Nice fix! |
electron0zero
added a commit
to electron0zero/tempo
that referenced
this pull request
Aug 22, 2022
This was referenced Aug 22, 2022
joe-elliott
pushed a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We are setting MaxIdleConnsPerHost in the customTransport used by Azure backend.
Default MaxIdleConnsPerHost is 2, Increase that to reduce connection turnover and hopefully fix the DNS failures seen in #1462
Which issue(s) this PR fixes:
Possible fix for #1462
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]