Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default max size and add troubleshotting page #1688

Merged
merged 4 commits into from Aug 26, 2022

Conversation

mapno
Copy link
Member

@mapno mapno commented Aug 24, 2022

What this PR does:

  • Increase default values for server.grpc_server_max_recv_msg_size and server.grpc_server_max_send_msg_size from 4MB to 16MB
  • Add a page in the troubleshot section for 500 Internal Server Error Body: response larger than the max (<size> vs <limit>) type of errors.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno marked this pull request as ready for review August 24, 2022 14:43
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks good! Thank you for adding documentation.

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
@mdisibio
Copy link
Contributor

This is great. What do you think about increasing the default for the frontend_worker to match?

@mapno
Copy link
Member Author

mapno commented Aug 25, 2022

This is great. What do you think about increasing the default for the frontend_worker to match?

This config is already at 100MB 🤯

@mapno mapno enabled auto-merge (squash) August 26, 2022 12:07
@mapno mapno merged commit fc83ff5 into grafana:main Aug 26, 2022
@mapno mapno deleted the msg-size-runbook branch August 26, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants