Add query parameter to search API for traceQL queries #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrhdn
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno and
zalegrala
as code owners
kvrhdn
commented
Sep 9, 2022
| @@ -21,6 +23,7 @@ import ( | |||
| const ( | |||
| URLParamTraceID = "traceID" | |||
| // search | |||
| urlParamQuery = "q" | |||
There was a problem hiding this comment.
I noticed Loki and Prometheus both use query instead. I think we opted for q since this is least likely to conflict with tag lookups using the old top-level query parameters.
Loki's API: https://grafana.com/docs/loki/latest/api/#query-loki
Prometheus' API: https://prometheus.io/docs/prometheus/latest/querying/api/#instant-queries
joe-elliott
reviewed
Sep 9, 2022
joe-elliott
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extends the search API to accept a query parameter
qwhich can optionally contain a traceQL query. Query is already validated but not yet implemented (it will return501 Not Implemented).Which issue(s) this PR fixes:
Fixes #Checklist
Documentation addedI'll add docs once traceQL queries are implementedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]