Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTel collector to v0.57.2 #1757

Merged
merged 9 commits into from
Sep 28, 2022
Merged

Conversation

mapno
Copy link
Member

@mapno mapno commented Sep 22, 2022

What this PR does:

Updates the OTel collector to v0.57.2. That is the latest version that is backwards compatible with the OTel proto changes introduced in #1754.

In order to remove the use of our internal OTel collector fork, some parts of the obsmetrics pkg have been copied over.

Which issue(s) this PR fixes:
Fixes #1746

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno changed the title Update otel collector Update OTel collector to v0.57.2 Sep 22, 2022
@mapno
Copy link
Member Author

mapno commented Sep 26, 2022

This PR breaks propagation of the OTel tracer as we drop the opentracing bridge fork.

@mapno mapno marked this pull request as ready for review September 26, 2022 16:06
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, but overall lgtm.

enough is changing in the distributor that we should watch performance as this rolls out.

modules/distributor/receiver/metrics.go Show resolved Hide resolved
modules/distributor/receiver/shim.go Show resolved Hide resolved
cmd/tempo-query/tempo/plugin.go Show resolved Hide resolved
@mapno mapno enabled auto-merge (squash) September 27, 2022 14:28
@mapno mapno merged commit 53d34ee into grafana:main Sep 28, 2022
@mapno mapno deleted the update-otel-collector branch September 28, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP HTTP Collector fails with error 'unknown field scopeSpans'
2 participants