cmd/tempo-vulture: share rand.Rand instance across multiple searches #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana#1760 noted that creating a new rand.Rand every time a random number is generated causes a poor distrubution of the search space, where numbers appear 7x more frequently than they do when using a shared rand.Rand instance. This is demonstrated using the following Go playground link: https://go.dev/play/p/EkhINRfOO5p This commit changes Vulture to use a shared rand.Rand instance instead of creating a new one each time a search or read is performed.
rfratto
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1760 noted that creating a new rand.Rand every time a random number is generated causes a poor distrubution of the search space, where numbers appear 7x more frequently than they do when using a shared rand.Rand instance.
This is demonstrated using the following Go playground link: https://go.dev/play/p/EkhINRfOO5p
This commit changes Vulture to use a shared rand.Rand instance instead of creating a new one each time a search or read is performed.
Closes #1760.