Add TLS support to vulture #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
zalegrala
force-pushed
the
vultureTLS
branch
from
c084043
to
b27125b
Compare
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
zalegrala
force-pushed
the
vultureTLS
branch
from
8e68fd0
to
a34244f
Compare
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno and
kvrhdn
as code owners
|
Note that this is only the write path. The query path should be simple, but I don't have a test up right now. Perhaps we can take that as another PR later? |
mapno
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a
tempo-tlsflag to enable TLS negotiation, but not verification, on the gRPC connection to Tempo.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]