Stop Distributor on fatal error #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* occasionally otel receivers will report a fatal error, and expected behavior is that the Host is stopped * match this behavior by stopping the receiver shim service and letting the distributor stop itself
rdooley
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
|
|
joe-elliott
reviewed
Nov 10, 2022
modules/distributor/receiver/shim.go
Outdated
| @@ -279,6 +279,7 @@ func (r *receiversShim) ConsumeTraces(ctx context.Context, td ptrace.Traces) err | |||
| // ReportFatalError implements component.Host | |||
| func (r *receiversShim) ReportFatalError(err error) { | |||
| _ = level.Error(log.Logger).Log("msg", "fatal error reported", "err", err) | |||
| r.StopAsync() | |||
There was a problem hiding this comment.
have you tested this? i honestly don't know the services code very well. this may simply stop the receiver, but not cause the distributor to exit.
There was a problem hiding this comment.
have not yet, writing an otel receiver mock to do so
There was a problem hiding this comment.
(it doesnt work, working on that)
There was a problem hiding this comment.
got this working by switching the shim to be a basicservice
Will update this PR with some testing results on Monday (fed holiday tomorrow I'm off)
|
Some context before I get into the testing:
After deleting this subscription observed And saw pods restart after the logged fatal error |
|
Oh I need to amend to add a changelog entry with the bugfix |
rdooley
force-pushed
the
distributor-fatal-error
branch
from
824de70
to
855104d
Compare
mapno
reviewed
Nov 17, 2022
* cant use idle service to do this i think * also add changelog entry * fix my bad copypaste
rdooley
force-pushed
the
distributor-fatal-error
branch
from
855104d
to
6310987
Compare
mapno
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
If you think we need a test added to prevent regression, let me know
Which issue(s) this PR fixes:
No Issue
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]