Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS support to jaeger query plugin #1999

Merged
merged 2 commits into from Jan 17, 2023

Conversation

rubenvp8510
Copy link
Contributor

@rubenvp8510 rubenvp8510 commented Jan 14, 2023

Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com

What this PR does:
This PR adds options to HTTP client to do TLS handshake with the query-frontend tempo API.

Something similar to what other components have:

Here is an example of the tempo-query config:

backend: 127.0.0.1:3100
tls_enabled: true
tls_cert_path: /var/run/tls/grpc/server/tls.crt
tls_key_path: /var/run/tls/grpc/server/tls.key
tls_ca_path: /var/run/ca/service-ca.crt
tls_insecure_skip_verify: false

Which issue(s) this PR fixes:
Fixes #1998

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@mapno
Copy link
Member

mapno commented Jan 17, 2023

LGTM. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TLS support to jaeger query plugin
2 participants