Propagate Ingesters search errors correctly #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
force-pushed
the
fix_2002
branch
from
3ec5af4
to
679b02d
Compare
electron0zero
changed the title
electron0zero
force-pushed
the
fix_2002
branch
from
679b02d
to
d1c5d17
Compare
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn and
zalegrala
as code owners
electron0zero
changed the title
electron0zero
force-pushed
the
fix_2002
branch
from
aeb7923
to
a5e54f8
Compare
joe-elliott
reviewed
Feb 1, 2023
joe-elliott
approved these changes
Feb 3, 2023
|
Hello @joe-elliott!
Please, if the current pull request addresses a bug fix, label it with the |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Bubble up ingesters search errors * Add errors support into Results * exit early in case of error * fix func doc * Update CHANGELOG.md * Move away from error channel to error atomic * cleanup * handle only errors case (cherry picked from commit 8d2853e)
joe-elliott
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Bubble up ingesters search errors * Add errors support into Results * exit early in case of error * fix func doc * Update CHANGELOG.md * Move away from error channel to error atomic * cleanup * handle only errors case (cherry picked from commit 8d2853e) Co-authored-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Collects and combines errors from Ingester search
Which issue(s) this PR fixes:
Fixes #2002
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]