-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "go test" with "gotestsum" in Makefile #2429
Conversation
@@ -94,37 +94,37 @@ benchmark: | |||
|
|||
# Not used in CI, tests are split in pkg, tempodb, tempodb-wal and others in CI jobs | |||
.PHONY: test-with-cover | |||
test-with-cover: test-serverless | |||
test-with-cover: tools test-serverless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative to the make target dependency here, we could add make tools
in the CI as a step.
|
||
|
||
# Import fragments | ||
include build/tools.mk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was a good time to start breaking up the make config a bit, but if we like it all in one, I can move these targets into the Makefile
.
The ALL_PKGS variable is empty for some reason and I've not looked why. |
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Signed-off-by: Zach Leslie <zach.leslie@grafana.com>
Feel free to review a test run here, as the output will be noticeable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this. one question below. also can we add golangci-lint and jsonnetfmt to the tools list?
does gofmt come with go? or should we add that to?
I agree other tools can be slotted in here, perhaps in a follow up PR. I like |
|
||
require ( | ||
github.com/psampaz/go-mod-outdated v0.9.0 | ||
gotest.tools/gotestsum v1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: why gotest.tools, and why not github? imo, I would trust github over gotest.tools to not serve me a bad or compromised verison of gotestsum :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure, but its in their recommendation for go install
, so that's what I'd put here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And indeed their module is gotest.tools
also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged, since this wasn't a blocking comment, but if we want to discuss and revisit I'm open to it.
What this PR does:
Here is a proposal to use
gotestsum
in place ofgo test
for the purpose of improving the output of the test results. Color adds a lot of context, and the particular format chosen here is one of many available.tools/
package and add initial go.modmake
targets for installing tools from sub directorytools
target as amake
dependency in several CI job taskstools/
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]