Query-frontend: allow unknown fields #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero and
ie-pham
as code owners
ie-pham
approved these changes
May 4, 2023
zalegrala
approved these changes
May 4, 2023
|
Interesting. |
mapno
pushed a commit
that referenced
this pull request
May 8, 2023
Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently if there is a mismatch between the json sent by the querier and the one expected by the query-frontend it will fail to parse. This was recently revealed with the rename of
inspectedBlocks->totalBlocks.This PR allows the frontend to leniently parse the response from the querier which prevent this issue and simplifies rollouts.