Add config param for autocomplete filtering #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
kvrhdn,
zalegrala,
electron0zero and
ie-pham
as code owners
electron0zero
approved these changes
May 8, 2023
| @@ -749,3 +750,90 @@ func BenchmarkInstanceSearchUnderLoad(b *testing.B) { | |||
| // exiting and cleaning up | |||
| time.Sleep(1 * time.Second) | |||
| } | |||
|
|
|||
| func TestExtractMatchers(t *testing.T) { | |||
There was a problem hiding this comment.
nit: let's also test a query that does math, so something like {.http.status_code = 200} = 1+1
mapno
added a commit
that referenced
this pull request
May 8, 2023
* Add config param for autocomplete filtering * Docs * Fix * Fix test * Address comments
mapno
added a commit
to mapno/tempo
that referenced
this pull request
May 10, 2023
* Add config param for autocomplete filtering * Docs * Fix * Fix test * Address comments
mapno
added a commit
that referenced
this pull request
May 10, 2023
…2447) * Add config param for autocomplete filtering (#2433) * Add config param for autocomplete filtering * Docs * Fix * Fix test * Address comments * Add job & instance labels to span metrics, a new target_info metrics, and the ability to customize dimension label mapping (#2261) * add job, instance, target_info * add test & gofmt * fmt & test * fix e2e test * add custom dimension mapping * updated test for custom mapping and changelog * fmt * changed the dimension mapping logic * fix test * update logic for job instance * fix test & lint * add service back and add gauge for target_info * added overrides and docs * undo config test change * typo * change traces_spanmetrics_target_info to just target_info * lint * fix overrides * handle batches with different resource attributes * redo counter * refactor registry * refactor label pair * oops * oops * rebase mishap * remove job instance by default * refactor * rebase hell * count * lint * remove arbitary number * traces_target_info * comments * sanitize labels for target info * small refactor to improve perf * rebased * rebased --------- Co-authored-by: Jennie Pham <94262131+ie-pham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add new param
autocomplete_filtering_enabledto configure filtering results in tag value search/api/v2/search/<tag>/values. If disabled, no filtering is done.It also fallbacks to no filtering if there is no query or it's invalid. It's much faster.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]