Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for jaeger query plugin #2438

Merged
merged 5 commits into from
May 30, 2023

Conversation

rubenvp8510
Copy link
Contributor

What this PR does:
This PR adds an e2e test fot the existing jaeger query plugin.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Leaving two comments, but LGTM overall.

integration/util.go Outdated Show resolved Hide resolved
integration/e2e/config-plugin-test.yaml Outdated Show resolved Hide resolved
@rubenvp8510 rubenvp8510 force-pushed the e2e_jaeger_query_plugin branch 2 times, most recently from 4bbf200 to a32cddf Compare May 17, 2023 03:02
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks!

@mapno mapno merged commit a7d9931 into grafana:main May 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants