Fix flaky tests #2439
Merged
Fix flaky tests #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
changed the title
mapno
changed the title
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mdisibio
approved these changes
May 9, 2023
joe-elliott
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
TestInstanceSearchDoesNotRaceis a test that frequently fails witherror opening file /<path>: error opening file: open /<path>: no such file or directoryThe assumption is that the test would end before all the concurrent functions had been executed and returned. Now it forces the test to wait for
concurrent()to wait to exit or the call to completeTest_counter_concurrencyCorrectnesswould fail converting fromuint64tofloat64Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]