Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep blocks for longer in e2e test #2448

Merged
merged 1 commit into from
May 10, 2023

Conversation

mapno
Copy link
Member

@mapno mapno commented May 10, 2023

What this PR does:

Increases ingester.complete_block_timeout in e2e test config to reduce probability of race condition.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 20s? why not 10m? or 1h?

hopefully this doesn't negatively impact any tests

@mapno
Copy link
Member Author

mapno commented May 10, 2023

why 20s? why not 10m? or 1h?

No reason, it seemed like a good value.

hopefully this doesn't negatively impact any tests

The other test using this config should benefit from this change as well.

@mapno mapno merged commit fe31111 into grafana:main May 10, 2023
14 checks passed
@mapno mapno deleted the e2e-test-improve-stability branch May 10, 2023 14:53
mapno added a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants