Copy tempo-query binary to /tempo-query #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previous implementation forces tempo to run with root privileges in Kubernetes because it is also writing to files in /tmp directory - this solution is inline to how other tempo components are built and ensures /tmp dir exists with mkdir -p
|
|
BertelBB
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
electron0zero
approved these changes
May 12, 2023
There was a problem hiding this comment.
lgtm 👍🏼
btw, tempo-query is an optional component and we sent a PR to disable it by default in helm chars
Co-authored-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
Thanks for feedback. I updated comment according to suggestion |
joe-elliott
reviewed
May 12, 2023
|
|
||
| # This is silly, but it's important that tempo-query gets copied into /tmp |
There was a problem hiding this comment.
you didn't like my cheeky comment ;) ?
There was a problem hiding this comment.
oh, @electron0zero suggested that!
There was a problem hiding this comment.
Haha I personally liked it and that’s why I initially kept that part in there 😄
There was a problem hiding this comment.
I was okay with either but wanted to sound like we know what we are doing 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the tempo-query Dockerfile such that it doesn’t copy
tempo-querybinary to /tmp dir but instead to root dir, i.e /tempo-query.Context:
Which issue(s) this PR fixes:
Fixes grafana/helm-charts#2024
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]