metrics-generator: use fanout storage to correctly update Prometheus remote write #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
May 11, 2023
CHANGELOG.md
Outdated
| @@ -31,6 +31,7 @@ To make use of filtering, configure `autocomplete_filtering_enabled`. | |||
| * [ENHANCEMENT] Add support for IPv6 [#1555](https://github.com/grafana/tempo/pull/1555) (@zalegrala) | |||
| * [ENHANCEMENT] Add span filtering to spanmetrics processor [#2274](https://github.com/grafana/tempo/pull/2274) (@zalegrala) | |||
| * [BUGFIX] tempodb integer divide by zero error [#2167](https://github.com/grafana/tempo/issues/2167) (@kroksys) | |||
| * [BUGFIX] metrics-generator: use fanout storage to correctly update Prometheus remote write [#2463](https://github.com/grafana/tempo/issues/2463) (@kvrhdn) | |||
There was a problem hiding this comment.
Will an end-user understand this?
Suggest to focus more on the effect, which I think is Tempo will now use multiple connections to send samples as the rate gets higher.
There was a problem hiding this comment.
Good point thanks! I tried to improve it somewhat
kvrhdn
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes a bug in our usage of the Prometheus
agent.DBandremote.Storagestructures. When we append data ontoagent.DBwe also need to append it ontoremote.Storageto ensureprometheus_remote_storage_highest_timestamp_in_secondsis updated (append implementation).This timestamp is used to determine how many shards are needed, since this metric wasn't updated desired shards is always set to 1, even if remote write is running behind and needs to catch up.
Which issue(s) this PR fixes:
Fixes #Checklist
Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]