Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix2308 latest #2473

Closed
wants to merge 8 commits into from
Closed

Fix2308 latest #2473

wants to merge 8 commits into from

Conversation

mghildiy
Copy link
Contributor

Summary of changes:

  • Add query parameter spss to API /api/search in http.go
  • Update http_test.go for new query parameter
  • to set number of spans during filtering
  • Update engine_test.go
  • Update instance_search_test.go

Adds a query parameter to Search API to make spans-per-span-set in response configurable::

Which issue(s) this PR fixes:
Fixes #2308

Checklist

  • [http_test.go, engine_test.go,instance_search_test.go ] Tests updated
  • [ docs/sources/tempo/api_docs/_index.md] Documentation added
  • [CHANGELOG.md] updated

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mghildiy
❌ manish chandra ghildiyal


manish chandra ghildiyal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mghildiy mghildiy closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query parameter to Search API to configure the spans per span set
2 participants