Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix2308: Add query parameter to Search API to configure spans-per-span-set in response #2474

Merged
merged 5 commits into from
May 15, 2023
Merged

fix2308: Add query parameter to Search API to configure spans-per-span-set in response #2474

merged 5 commits into from
May 15, 2023

Conversation

mghildiy
Copy link
Contributor

Summary of changes:

  • Add query parameter spss to API /api/search in http.go
  • set number of spans during filtering
  • Update http_test.go for new query parameter
  • Update engine_test.go
  • Update instance_search_test.go

Adds a query parameter to Search API to make spans-per-span-set in response configurable::

Which issue(s) this PR fixes:
Fixes #2308

Checklist

  • [http_test.go, engine_test.go,instance_search_test.go ] Tests updated
  • [docs/sources/tempo/api_docs/_index.md] Documentation added
  • [CHANGELOG.md] updated

@mghildiy mghildiy mentioned this pull request May 13, 2023
Closed
joe-elliott
joe-elliott approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Thanks for the help.

@joe-elliott joe-elliott merged commit ae0251f into grafana:main May 15, 2023
14 checks passed
@mghildiy mghildiy deleted the fix2308CLAIssue branch May 15, 2023 12:33
@joe-elliott joe-elliott mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott joe-elliott approved these changes

@knylander-grafana knylander-grafana Awaiting requested review from knylander-grafana knylander-grafana is a code owner

@annanay25 annanay25 Awaiting requested review from annanay25 annanay25 is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@kvrhdn kvrhdn Awaiting requested review from kvrhdn kvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add query parameter to Search API to configure the spans per span set
2 participants
@mghildiy @joe-elliott