Add range in traceql search for vulture #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested in ops overnight and things look good |
ie-pham
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero and
stoewer
as code owners
joe-elliott
approved these changes
May 15, 2023
cmd/tempo-vulture/main.go
Outdated
| @@ -262,6 +263,7 @@ func pushMetrics(metrics traceMetrics) { | |||
| metricTracesErrors.WithLabelValues("incorrectresult").Add(float64(metrics.incorrectResult)) | |||
| metricTracesErrors.WithLabelValues("missingspans").Add(float64(metrics.missingSpans)) | |||
| metricTracesErrors.WithLabelValues("notfound_search").Add(float64(metrics.notFoundSearch)) | |||
| metricTracesErrors.WithLabelValues("notfound_search").Add(float64(metrics.notFoundTraceQL)) | |||
There was a problem hiding this comment.
we should change the reason label from notfound_search to notfound_traceql or something
pkg/util/client.go
Outdated
|
|
||
| func (c *Client) SearchTraceQLWithRange(query string, start int64, end int64) (*tempopb.SearchResponse, error) { | ||
| m := &tempopb.SearchResponse{} | ||
| _, err := c.getFor(c.BaseURL+"/api/search?q="+url.QueryEscape(query)+"&start="+strconv.FormatInt(start, 10)+"&end="+strconv.FormatInt(end, 10), m) |
There was a problem hiding this comment.
i think there are more correct ways to build a query string like this. likely using the url object and then asking it to encode all at once, but this is fine given what we're doing here
ie-pham
commented
May 16, 2023
| return m, nil | ||
| } | ||
|
|
||
| func (c *Client) buildQueryURL(queryType string, query string, start int64, end int64) string { |
There was a problem hiding this comment.
@joe-elliott not sure if this is better... I can just revert it to the old ways of building url if not
There was a problem hiding this comment.
up to you. if it works it works. i do think this is "more correct"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Vulture was doing test traceql queries for but since time range was not added in the query, it was getting false errors
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/tempo-squad/issues/240
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]