Add spanset attributes #2478
Merged
Add spanset attributes #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
This reverts commit d5eeb74.
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
mapno
approved these changes
May 17, 2023
Comment on lines
+488
to
+499
| case TypeStatus: | ||
| if s.Status > other.Status { | ||
| return 1 | ||
| } else if s.Status < other.Status { | ||
| return -1 | ||
| } | ||
| case TypeKind: | ||
| if s.Kind > other.Kind { | ||
| return 1 | ||
| } else if s.Kind < other.Kind { | ||
| return -1 | ||
| } |
There was a problem hiding this comment.
Does this comparison make sense for status and kind? What does a status bigger than another mean?
There was a problem hiding this comment.
I agree that it's strange and one status isn't really comparable to another status in this way. The only reason I included them was so that if we were to sort Statics like Kind/Status using this function the results would be deterministic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR does some cleanup in preparation for passing arbitrary attributes through the Fetch method.
In order to keep these PRs more easily reviewable I'm going to cut this off here. Next I will work on actually preserving these through the fetch layer.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]