Local blocks processor query all blocks #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
joe-elliott,
annanay25,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mapno
approved these changes
May 17, 2023
| if p.headBlock == nil { | ||
| return traceql.FetchSpansResponse{}, fmt.Errorf("head block is nil") | ||
| // Blocks to check | ||
| blocks := make([]common.BackendBlock, 0, 1+len(p.walBlocks)+len(p.completeBlocks)) |
There was a problem hiding this comment.
This is going to create a lot of memory pressure with each read by copying memory around. We could loop through the blocks directly instead.
There was a problem hiding this comment.
Good point. I wonder if we could keep this blocks object on the struct, since we're already locking, we could keep it updated on the iteration but not need to re-allocate new memory.
There was a problem hiding this comment.
I took this approach because it greatly simplifies the below logic and error handling, one loop instead of two or three (head block, wal blocks, complete blocks). The overhead of this slice should be minimal - expect a few dozen blocks and single digit requests per second to this api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR is part of a wider initiative to perform on-demand metrics calculations. Updates the
/generator/api/metricsAPI to query all blocks. Includes some basic caching with simplelru that definitely needs to be replaced with something more robust. Finally added a test but it's a good one 😬Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]