Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide streaming querier service over HTTP #2485

Merged
merged 6 commits into from
May 24, 2023

Conversation

joe-elliott
Copy link
Member

What this PR does:
Provides the new streaming querier interface over the HTTP port for Grafana cc @adrapereira

Updates a few dependencies to make this happen.

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@@ -78,6 +78,10 @@ func (t *App) initServer() (services.Service, error) {

DisableSignalHandling(&t.cfg.Server)

// this allows us to server http and grpc over the primary http server.
// to use this register services with GRPCOnHTTPServer
t.cfg.Server.RouteHTTPToGRPC = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shaking_eyes:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Collaborator

@stoewer stoewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-elliott joe-elliott merged commit 1dc1bfe into grafana:main May 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants