TraceQL: Grouping #2490
TraceQL: Grouping #2490
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
knylander-grafana,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
After much hand-wringing I decided to deprecate the current "SpanSet" field on the return in favor of "SpanSets".
For now the SpanSet field is a "random" spanset from the slice. For queries that do not create multiple spansets per trace (i.e. everything but |
| @@ -90,34 +96,23 @@ type Spanset struct { | |||
| RootServiceName string | |||
| StartTimeUnixNanos uint64 | |||
| DurationNanos uint64 | |||
| Attributes map[string]Static | |||
| Attributes []*SpansetAttribute | |||
There was a problem hiding this comment.
What is the reason for the slice over a map? Also map[string]Static wasn't right, it probably should be map[Attribute]Static
There was a problem hiding this comment.
the order is meaningful and needs to be preserved b/c it's established by the query, but the map can't preserve the order.
| func spansetID(ss *tempopb.SpanSet) string { | ||
| id := "" | ||
|
|
||
| for _, s := range ss.Attributes { |
There was a problem hiding this comment.
Initial thought is that the whole Attributes slice could uniquely define the spanset. Does it contain attributes we don't want?
There was a problem hiding this comment.
yeah, if the attributes are:
by(.namespace) = "prod"
by(.service.name) = "app"
avg(duration) = 1.32ms
we only want to use the first 2 to identify the spanset
| // use otherEntryCallbackSpansetKey to indicate to the rebatchIterator that either | ||
| // 1) this is the last span in the spanset, or 2) there are more spans in the spanset | ||
| span.cbSpansetFinal = idx == len(ss.Spans)-1 | ||
| span.cbSpanset = ss |
There was a problem hiding this comment.
Instead of a bool on the last span, we could probably rebatch them based on equal ss pointers.
There was a problem hiding this comment.
we could do that, but then the rebatchIterator would have to call Next() until it received a nil span to guarantee its batches were complete. Then it would be able to dump all batches. I did this to preserve the "streaming" nature of the iterators
Signed-off-by: Joe Elliott <number101010@gmail.com>
What this PR does:
by()andcoalesce()to the language. Purposefully only documentsby()b/c I can't think of a use case forcoalesce()and I want to keep docs focused.TODO:
Which issue(s) this PR fixes:
Fixes #2136
Fixes #2307
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]