[vparquet3] Add command to tempo-cli to analyse blocks for dedicated columns #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
stoewer
requested changes
Jul 14, 2023
cmd/tempo-cli/cmd-analyse-block.go
Outdated
Comment on lines
60
to
64
| case vparquet.VersionString: | ||
| return vparquet.FieldSpanAttrKey, vparquetSpanAttrs | ||
| case vparquet2.VersionString: | ||
| return vparquet2.FieldSpanAttrKey, vparquet2SpanAttrs | ||
| } |
There was a problem hiding this comment.
I assume this will be vParquet2 and vParquet3 as soon as vParquet3 is realeased?
tempodb/encoding/vparquet/block.go
Outdated
|
|
||
| func newBackendBlock(meta *backend.BlockMeta, r backend.Reader) *backendBlock { | ||
| return &backendBlock{ | ||
| func NewBackendBlock(meta *backend.BlockMeta, r backend.Reader) *BackendBlock { |
There was a problem hiding this comment.
I'm wondering whether there is an alternative to making this function and BackendBlock public. Maybe the CLI could have a thin wrapper around backend.ContextReader that implements an io.ReaderAt that can be passed into parquet.OpenFile()
There was a problem hiding this comment.
Used NewBackendReaderAt() and passed the reader to parquet.OpenFile() instead. No need to export BackendBlock nor any of its methods. Nice call.
|
|
||
| ## Analyse blocks | ||
| Analyses all blocks in a given time range and outputs a summary of the blocks' generic attributes. | ||
| It's of particular use when trying to determine what attributes to configure for dedicated columns in vParquet3. |
There was a problem hiding this comment.
Maybe link to the dedicated columns page (PR#2664)?
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
NOTE: Depends on
vparquet3being merged tomainAdds two new methods to
tempo-clito analyse parquet blocks and output summaries of generic attribute columns:Analyse block
Analyses a block and outputs a summary of the block's generic attributes.
It's of particular use when trying to determine what attributes to configure for dedicated columns in vParquet3.
Arguments:
tenant-idThe tenant ID. Usesingle-tenantfor single tenant setups.block-idThe block ID as UUID string.Options:
--num-attr <value>Number of attributes to output (default: 10)Example:
Analyse blocks
Analyses all blocks in a given time range and outputs a summary of the blocks' generic attributes. It's of particular use when trying to determine what attributes to configure for dedicated columns in vParquet3.Arguments:
tenant-idThe tenant ID. Usesingle-tenantfor single tenant setups.Options:
--num-attr <value>Number of attributes to output (default: 10)--min-compaction-level <value>Minimum compaction level to include in the analysis (default: 3)--max-blocks <value>Maximum number of blocks to analyse (default: 10)Example:
Which issue(s) this PR fixes:
Fixes #2630
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]