[Jsonnet] Make metrics-generator deployment volume mounts customizable #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownstream jsonnet from changing them via $.tempo_metrics_generator_container, make volume mounts idential between deployment and statefulset
mdisibio
requested review from
joe-elliott,
annanay25,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
zalegrala
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The microservices jsonnet was using
container.withVolumeMountson the generator deployment, and this prevents downstream users of the jsonnet from customizing the mounts through the$.tempo_metrics_generator_container. Except they still worked for the statefulset because it doesn't do that, which is unexpected and hard to troubleshoot.The root cause was that we were attempting to keep the volume mounts on the deployment set to
/var/tempo/walbut let the statefulset mount at/var/tempo(because of the new metrics feature that uses/var/tempo/blocks). So the fix here is both removingwithVolumeMountsand making the mounts the same between both deployment modes. This addresses the downstream customize issue, but also simplifies.Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]