Add warnings for suspect configurations #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
requested changes
Oct 30, 2020
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
dgzlopes
force-pushed
the
warnings-for-suspect-configurations
branch
from
054cac4
to
4ff5c60
Compare
dgzlopes
commented
Oct 31, 2020
| @@ -76,6 +76,9 @@ func main() { | |||
| // Allocate a block of memory to alter GC behaviour. See https://github.com/golang/go/issues/23044 | |||
| ballast := make([]byte, *ballastMBs*1024*1024) | |||
|
|
|||
| // Warn the user for suspect configurations | |||
| config.CheckConfig() | |||
|
|
|||
There was a problem hiding this comment.
Moved the check to its own method. I'm not sure if the method name is descriptive enough 😅
joe-elliott
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Warns the user if the configuration looks strange.
Which issue(s) this PR fixes:
Fixes #244
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]