Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics debugging options #3008

Merged
merged 7 commits into from Oct 12, 2023
Merged

Add metrics debugging options #3008

merged 7 commits into from Oct 12, 2023

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Oct 11, 2023 •
edited

What this PR does:
Adds a config block to the distributor to produce debug metrics. These can be particularly useful when tracking down a process that is creating an exceptional amount of spans.

distributor:
  metric_received_spans:
    enabled: false
    root_only: false

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
first pass
0aaae53 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
stuff
bf251b2 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
fix tests. replace warning
dbbf493 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
manifest
1a8bc90 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
docs
9bc354d 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
changelog
413e92d 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
lint
b64760f 
Signed-off-by: Joe Elliott <number101010@gmail.com>
electron0zero
electron0zero approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@electron0zero electron0zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

ps: didn't test locally.

@joe-elliott joe-elliott merged commit 67fd171 into grafana:main Oct 12, 2023
15 checks passed
@knylander-grafana knylander-grafana mentioned this pull request Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electron0zero electron0zero electron0zero approved these changes

@knylander-grafana knylander-grafana Awaiting requested review from knylander-grafana knylander-grafana is a code owner

@annanay25 annanay25 Awaiting requested review from annanay25 annanay25 is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@kvrhdn kvrhdn Awaiting requested review from kvrhdn kvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joe-elliott @electron0zero