make the traceID label name configurable #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
|
should I add a new config to legacy config - or adjust this test? |
zeitlinger
requested review from
jdbaldry and
knylander-grafana
as code owners
joe-elliott
reviewed
Oct 27, 2023
There was a problem hiding this comment.
This generally looks good to me! What is the goal here? Do we need this to be per tenant?
I'm not going to approve b/c I'd like @kvrhdn to take a look regarding how this interacts with overrides/user configurable overrides.
joe-elliott
reviewed
Oct 27, 2023
I think ultimately we want to migrate everyone over, so I see this as a feature flag. |
|
@knylander-grafana fixed build |
kvrhdn
reviewed
Nov 13, 2023
|
@kvrhdn can this be merged now? |
addressed |
kvrhdn
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: make the traceID label name configurable, especially to make it possible to be otel compliant: https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]